Add parameter to set the logging level for TestLogger#2873
Open
labkey-tchad wants to merge 4 commits intodevelopfrom
Open
Add parameter to set the logging level for TestLogger#2873labkey-tchad wants to merge 4 commits intodevelopfrom
labkey-tchad wants to merge 4 commits intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
While debugging a test failure, I realized that there isn't a way to configure our tests' log level without modifying the
log4j2.xmlconfig file. Fixing this introduced a circular dependency in the static initialization ofTestLoggerandTestProperties. I introduced a separate logger toTestPropertiesto avoid this (WebTestHelperhas its own logger for a similar reason).Related Pull Requests
Changes
webtest.log.level) to set the logging level for TestLoggerTestLoggerandTestPropertiesWebDriverWrapper.waitForPageToLoadto work better on Chrome