fix: ensure proper cleanup of SSE events with AbortController#731
Conversation
These files were removed from tracking in 46a731f (chore: remove test_snapshots from tracking, add to .gitignore) but were re-committed in subsequent feature branches without being caught by the ignore rule. The policy is clear: test_snapshots/ is auto-generated by the Soroban test runner and must never be committed. No .gitignore changes needed.
vitest.config.ts sets coverage.provider = 'v8', which requires @vitest/coverage-v8 as a peer. It was missing from devDependencies, causing CI to fail with MISSING DEPENDENCY on npm test.
…tion/purity/effect rules
…pshots chore: untrack 5 snapshot JSONs re-committed after 46a731f
ogazboiz
left a comment
There was a problem hiding this comment.
clean — closes #651 (SSE/stream-detail fetches now wrap in AbortController for cleanup on unmount). all CI green. merging!
join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
…eware-unknown-error-type chore: replace err any with unknown and narrow safely
…-magic-numbers Fix/pagination magic numbers
|
approved! but a couple of conflicting merges landed first and now this branch is DIRTY. quick rebase and it can land: git fetch upstream
git rebase upstream/main
git push --force-with-leasei'll auto-merge as soon as it's clean. |
|
ok thank you |
|
after rebase, the stricter tsconfig you enable in this PR (#651's noImplicitReturns / noFallthroughCasesInSwitch) now catches a real issue: a switch or if-chain in TransactionTracker.tsx around line 152 has a branch that falls through without returning. add the missing return (or refactor to an exhaustive switch with a default). once that's fixed, the build should pass. |
Closes #651
What
Enabled noImplicitReturns and noFallthroughCasesInSwitch in frontend/tsconfig.json
and fixed all errors these flags surfaced.
Why
These two flags are cheap strictness wins that catch real bugs — functions with
inconsistent return paths and switch statements with missing breaks — before they
ship to production.
Changes
and dashboard-view renderContent
Testing
Notes