Skip to content

fix(ci): route fork artifacts to current repository#684

Open
100yenadmin wants to merge 1 commit into
LadybugDB:mainfrom
100yenadmin:fix/fork-artifact-repository
Open

fix(ci): route fork artifacts to current repository#684
100yenadmin wants to merge 1 commit into
LadybugDB:mainfrom
100yenadmin:fix/fork-artifact-repository

Conversation

@100yenadmin

Copy link
Copy Markdown

Summary

  • route workflow artifact downloads to the current GitHub repository when a
    precompiled run ID is provided
  • preserve LBUG_GITHUB_REPOSITORY as the highest-priority explicit override
  • preserve LadybugDB/ladybug as the default for release downloads
  • add a subprocess regression test to the existing sanity job

Root cause

GitHub Actions run IDs are repository-scoped, but
scripts/download-liblbug.sh always defaulted to LadybugDB/ladybug.
Dispatching the reusable language workflows in a fork therefore queried the
upstream repository with a fork run ID and returned HTTP 404.

Fixes #683.

Validation

  • observed the original test fail on the current upstream script
  • scripts/test-download-liblbug.sh
  • bash -n scripts/download-liblbug.sh scripts/test-download-liblbug.sh
  • shellcheck scripts/download-liblbug.sh scripts/test-download-liblbug.sh
  • parsed .github/workflows/ci-workflow.yml with Ruby YAML
  • downloaded a real fork artifact from run 29227829393 with only
    GITHUB_REPOSITORY=100yenadmin/ladybug
  • git diff --check

No package publication or deployment is requested.

@100yenadmin 100yenadmin marked this pull request as ready for review July 13, 2026 07:36
@100yenadmin

Copy link
Copy Markdown
Author

@coderabbitai review

"override-owner/ladybug"

unset LBUG_GITHUB_REPOSITORY LBUG_PRECOMPILED_RUN_ID
export LBUG_VERSION="0.18.1"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove references to 0.18.x. Makes it hard to bump version numbers on the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fork workflow dispatch cannot download artifacts from the fork

2 participants