Forward parameters to acclint/acceptance-lint, add bundlelock alias#192
Open
chrisdebian wants to merge 1 commit into
Open
Forward parameters to acclint/acceptance-lint, add bundlelock alias#192chrisdebian wants to merge 1 commit into
chrisdebian wants to merge 1 commit into
Conversation
…lias
acceptance-lint and acclint ran run_linting.sh with no way to pass
extra arguments through, unlike acctest/acceptance-test next to them
which already forward "${@:2}". Bring them into line so linting
scripts can accept flags (e.g. auto-fix) the same way test scripts
accept cucumber args.
Also adds a bundlelock alias, following the same ex/manage() pattern,
to run `bundle lock` in a container - optionally scoped to specific
gem names to update just those.
Closes LandRegistry#145.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #145.
acceptance-lint/acclintranrun_linting.shwith no way to pass extra arguments through — unlikeacctest/acceptance-testright next to them, which already forward"${@:2}". This brings them into line, so linting scripts can accept flags (e.g. auto-fix) the same way test scripts accept cucumber args. No-argument invocations are unchanged (verified with a mockrun/exharness before opening this).bundlelockis a new alias, following the existingex/manage()pattern:Runs
bundle lockin the container, updatingGemfile.lock; optionally pass gem names to scope the update to just those gems, per the issue's ask.Both new/changed forwards use quoted
"${@:2}"rather than the unquoted${@:2}style used elsewhere in this file (e.g.manage()) — deliberately, to avoid the word-splitting bug that turned out to be the real cause of #180 (see LandRegistry/skeleton-acceptance-tests#33 for the full trace).Testing:
bash -nsyntax-checked; behaviour verified with mockrun/exfunctions standing in for the real docker-compose-backed ones (I don't have a running app container to exercise this against for real).