feat(fullscreen): implement dynamic playbar resizing and update layout handling#209
Merged
LargeModGames merged 2 commits intomainfrom Apr 9, 2026
Merged
Conversation
Owner
Author
|
closes #208 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates how the fullscreen lyrics and cover art views handle the playbar, making its height fully configurable and allowing it to be hidden or resized with existing keybindings. The implementation now consistently honors the user's playbar height setting across fullscreen views, improves the centering of cover art when the playbar is hidden, and adds comprehensive tests for these behaviors.
Fullscreen playbar resizing and layout improvements:
fullscreen_view_layoutfunction incore/layout.rsto calculate the content and playbar areas in fullscreen views based on the configured playbar height. If the playbar height is set to zero, the playbar is hidden and the content area fills the screen. Includes new tests for these behaviors. [1] [2]draw_lyrics_view,draw_cover_art_viewinui/player.rs) to use the new layout logic, so the playbar area is only rendered if its height is nonzero.Cover art centering and sizing fixes:
Code cleanup and documentation:
FULLSCREEN_VIEW_PLAYBAR_HEIGHTconstant in favor of using the user-configured value throughout the codebase. [1] [2]