Write modules.json incrementally during installation#452
Merged
Conversation
## Description Previously, modules.json was only written once at the end of installation. If any module failed during installation, the file would not reflect the partial progress, leaving the installation in an inconsistent state. This change makes modules.json sync after each module completes (success or failure), ensuring the file always reflects actual installation state. Installation also continues past failures, collecting all errors. ## Changes * [ADD] `write_modules_json` helper function for incremental state persistence * [ADD] `ModuleInstaller` trait to enable testing with mock installers * [ADD] `MultipleInstallFailures` error variant for reporting multiple failures * [ADD] Test infrastructure with JSON fixtures and MockModuleInstaller * [ADD] Integration tests for partial failure scenarios and state persistence * [FIX] `install_module_and_dependencies` now collects errors and continues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, modules.json was only written once at the end of installation. If any module failed during installation, the file would not reflect the partial progress, leaving the installation in an inconsistent state.
This change makes modules.json sync after each module completes (success or failure), ensuring the file always reflects actual installation state. Installation also continues past failures, collecting all errors.
Changes
write_modules_jsonhelper function for incremental state persistenceModuleInstallertrait to enable testing with mock installersMultipleInstallFailureserror variant for reporting multiple failuresinstall_module_and_dependenciesnow collects errors and continuesTest plan
write_modules_jsonhelper