Fix modules.json installation after editor failure#453
Merged
Conversation
## Description Improve error handling in the module installation pipeline to properly distinguish between Editor and module failures, and clean up partial installations when the Editor itself fails during a fresh install. ## Changes * [ADD] `EditorInstallationFailed` and `ModuleInstallationsFailed` variants to `InstallError` * [FIX] Clean up installation directory when Editor installation fails on fresh install * [FIX] Return early on Editor failure without attempting module installs * [UPDATE] `install_modules_with_installer()` and `install_module_and_dependencies()` return `Result<()>` instead of `Vec<InstallError>` * [ADD] Tests covering editor failure cleanup, module failure collection, and success scenarios * [ADD] `editor-failure-cleanup` spec * [UPDATE] `incremental-modules-sync` spec with Editor failure exception clause
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve error handling in the module installation pipeline to properly distinguish between Editor and module failures, and clean up partial installations when the Editor itself fails during a fresh install.
Changes
EditorInstallationFailedandModuleInstallationsFailedvariants toInstallErrorinstall_modules_with_installer()andinstall_module_and_dependencies()returnResult<()>instead ofVec<InstallError>editor-failure-cleanupspecincremental-modules-syncspec with Editor failure exception clause