Fix panic on empty integrity string from live platform API#455
Merged
Fix panic on empty integrity string from live platform API#455
Conversation
## Description
Newer Unity versions return an empty string for the `integrity` field
instead of `null`. `ssri::Integrity::from_str("")` silently produces an
`Integrity` with zero hashes, causing `i.check()` to panic with an
index-out-of-bounds error during checksum verification.
## Changes
* ![FIX] Treat empty `integrity` string as `None` in `deserialize_sri` via `Some(s) if s.is_empty()` guard
* ![ADD] Unit tests for `deserialize_sri` covering empty string, null, missing field, and valid SRI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Newer Unity versions return an empty string for the
integrityfield instead ofnull.ssri::Integrity::from_str("")silently produces anIntegritywith zero hashes, causingi.check()to panic with an index-out-of-bounds error during checksum verification.Changes
integritystring asNoneindeserialize_sriviaSome(s) if s.is_empty()guarddeserialize_sricovering empty string, null, missing field, and valid SRI