Skip to content

Add option to remove animated sliding effect #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SteveX wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add option to remove animated sliding effect #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01bcc76
Add option to remove animated slide effect
SteveX Jul 16, 2019
bc71ee5
Remove animated slide effect if property is set
SteveX Jul 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion js/adapt-contrib-blockslider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,11 @@ define([

navigateToIndex: function(stage, movementSize) {
if (stage < this.model.get('_blockCount') && stage >= 0) {
this.$('.blockslider').stop().animate({'margin-left': - (movementSize * stage)});
if (this.model.get('_blockSlider')._noAnimate === true) {
this.$('.blockslider').stop().css({'margin-left': - (movementSize * stage)});
} else {
this.$('.blockslider').stop().animate({'margin-left': - (movementSize * stage)});
}
this.setStage(stage);
}
},
Expand Down
11 changes: 10 additions & 1 deletion properties.schema
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,16 @@
"inputType": "Text",
"validators": ["required"],
"help": "Fix the height of the blockslider to this value. For example, a value of 600 will set the blockslider to 600px high. Defaults to 'auto' if not specified."
}
},
"_noAnimate": {
"type": "boolean",
"required": false,
"default": false,
"title": "No animation",
"inputType": {"type": "Boolean", "options": [true, false]},
"validators": [],
"help": "Set to true to remove the animated sliding effect."
}
}
}
}
Expand Down