Refactor integration suite and CI#11
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the integration test suite from Python (pytest) to Zig, removing all Python dependencies and replacing the test runner with a self-contained Zig script. The change simplifies the development environment and CI/CD pipeline by eliminating the need for Python and the uv package manager.
Changes:
- Replace Python/pytest integration test runner (
scripts/integration.py) with a Zig implementation (scripts/integration.zig) - Update GitHub Actions workflows to use the new Zig test runner and simplified action references
- Update documentation (README.md and CONTRIBUTING.md) to reflect the new test invocation command
- Simplify devcontainer configuration by removing Python-specific security options
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/integration.zig | New Zig-based integration test runner with test discovery, execution, and golden file comparison |
| scripts/integration.py | Removed Python/pytest test runner |
| README.md | Updated testing instructions to use zig run scripts/integration.zig |
| CONTRIBUTING.md | Updated development workflow and test execution documentation |
| .github/workflows/ci.yml | Simplified to use Zig action directly and removed Python dependencies |
| .github/workflows/release.yml | Simplified action references |
| .devcontainer/devcontainer.json | Removed Python-specific security options |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0pendev
force-pushed
the
refactor/integration_suite
branch
from
f2b267d to
aa53c67
Compare
Signed-off-by: Francisco Freitas <francisco.freitas@ledger.fr>
Signed-off-by: Francisco Freitas <francisco.freitas@ledger.fr>
Signed-off-by: Francisco Freitas <francisco.freitas@ledger.fr>
Reject non-semver values from PR-controlled build.zig.zon so URL, install path, and GITHUB_PATH cannot be manipulated by untrusted input.
Signed-off-by: Francisco Freitas <francisco.freitas@ledger.fr>
0pendev
force-pushed
the
refactor/integration_suite
branch
from
aa53c67 to
b6909c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waiting for #10
Fix #4 #3