Conversation
lemonbar.c
Outdated
|
|
||
| *input = 0; | ||
| while (fgets(input, sizeof input, stdin)) { } | ||
| if (!*input) { |
There was a problem hiding this comment.
No need for this, this case is already handled by parse. Moreover this way you don't clear the bar when an empty string is read.
|
Also, the commit messages should be reworded
Other than that the PR looks fine, /hopefully/ it fixes the problem @woho has. |
Read input lines in non-blockin mode and parse the last one. Should fix LemonBoy#107
|
Reworded the commit messages and adopted coding style. EDIT: The WM_CLASS atom has its own PR: #187 |
|
This PR is about fixing the multiline issue, open another one for the |
|
Sorry, I've forgot to check the last commit. I will split the PR into two: multiline issue and WM_CLASS. I haven't planned releasing this PR so soon, so the |
|
The WM_CLASS commits now have their own PR: #187 |
|
I object to merging this PR, since with these changes the same bug will happen as has been observed by @LemonBoy in a slightly different context.
The reason for this breakage is that the statusbar script uses With a blocking With a non-blocking While this does improve performance and fix the |
|
This PR has been made redundant by the superior changes in 9e35bd6. Please close. |
Fixed Issue #107.
Added wm class string, so it's easier to handle lemonbar in compton, xdotool, etc.