Skip to content

fix: correct taiga grape seed item IDs in winemaker trades#77

Closed
Gardelll wants to merge 1 commit into
Let-s-Do-Collection:1.21.1from
Gardelll:1.21.1
Closed

fix: correct taiga grape seed item IDs in winemaker trades#77
Gardelll wants to merge 1 commit into
Let-s-Do-Collection:1.21.1from
Gardelll:1.21.1

Conversation

@Gardelll
Copy link
Copy Markdown

Fixes winemaker villager trades using incorrect item IDs for taiga grape seeds (taiga_red_grape_seedstaiga_grape_seeds_red, taiga_white_grape_seedstaiga_grape_seeds_white), which causes EncoderException: Empty ItemStack not allowed and disconnects the player when opening the level 4 trading UI.

Also adds Items.AIR guard in NeoForge loadTradesFromConfig to match Fabric's existing check.

Fixes Let-s-Do-Collection/Let-s-Do-Collection#946
Relates to Let-s-Do-Collection/Let-s-Do-Collection#882

@Gardelll
Copy link
Copy Markdown
Author

Closing as duplicate of #76.

@Gardelll Gardelll closed this Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Vinery] Bad trade in journeyman-level winemaker trade pool

1 participant