Remove trailing stroke from path before file download#7
Open
rosagierens wants to merge 1 commit into
Open
Conversation
When downloading from aws, having 2 slashes leads to file not found.
yuyao-cyber
approved these changes
Dec 22, 2025
yuyao-cyber
left a comment
yuyao-cyber
left a comment
There was a problem hiding this comment.
The fix avoids the double slash situation (when using a trailing slash). Tested correct
ihough
added a commit
to GEOS-Chem-IGE/bashdatacatalog
that referenced
this pull request
May 29, 2026
Use parameter expansion to remove trailing urls in bashdatacatalog-fetch This aligns with the (currently unmerged) pull request upstream LiamBindle#7
|
We should not be using upstream for GEOS-Chem anymore. All fixes should go to https://github.com/geoschem/bashdatacatalog. @yuyao-cyber, can you confirm that Liam's repo is not used anywhere and is not mentioned in the docs other than specifying we use a fork of it? |
yuyao-cyber
added a commit
to geoschem/bashdatacatalog
that referenced
this pull request
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When downloading from aws, having 2 slashes leads
to file not found.