Skip to content

[BUG] Socket not always closed #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saviorand merged 2 commits into from
Feb 22, 2026
Merged

[BUG] Socket not always closed #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
833dc9d
remove platform guard on reuseaddr
saviorand Feb 22, 2026
9f267fb
add devcontainer.json
saviorand Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"name": "Lightbug HTTP (Linux)",
"image": "ghcr.io/prefix-dev/pixi:latest",
"postCreateCommand": "apt-get update && apt-get install -y git && pixi install",
"forwardPorts": [8080],
"customizations": {
"vscode": {
"extensions": ["modular-mojotools.vscode-mojo"]
}
}
}
13 changes: 5 additions & 8 deletions lightbug_http/connection.mojo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,14 +239,11 @@ struct ListenConfig:
except socket_err:
raise SocketCreationError()

@parameter
# TODO: do we want to add SO_REUSEPORT on linux? Doesn't work on some systems
if CompilationTarget.is_macos():
try:
socket.set_socket_option(SocketOption.SO_REUSEADDR, 1)
except sockopt_err:
# Socket option failure is not fatal, just continue
pass
try:
socket.set_socket_option(SocketOption.SO_REUSEADDR, 1)
except sockopt_err:
# Socket option failure is not fatal, just continue
pass

var addr = TCPAddr[network](ip=local.host^, port=local.port)
var bind_success = False
Expand Down