chore: wip renaming #2177
Draft
chore: wip renaming #2177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (5)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Comment on lines
+22
to
+26
| | `token-sdk/src/compressed_token/v2/account2.rs` | `CTokenAccount2` | `LightTokenAccount` or `TokenAccount2` | | ||
| | `token-sdk/src/compressed_token/v1/account.rs` | `CTokenAccount` | `LightTokenAccount` or `TokenAccountV1` | | ||
| | `token-sdk/src/pack.rs` | `CTokenDataWithVariant<V>` | `LightTokenDataWithVariant<V>` | | ||
| | `token-types/src/account_infos/transfer.rs` | `CTokenProgram` (enum variant) | `LightTokenProgram` | | ||
| | `compressible-client/src/decompress_atas.rs` | `CTokenAccount2` usage | `LightTokenAccount` | |
Contributor
There was a problem hiding this comment.
these are still compressed tokens left it ctoken as short for compressed token. Thought we would only rename solana account ctokens to light tokens.
| ### 1.4 Traits | ||
| | File | Current | Proposed | | ||
| |------|---------|----------| | ||
| | `token-sdk/src/compressed_token/ctoken_instruction.rs` | `CTokenInstruction` | `LightTokenInstruction` | |
Contributor
There was a problem hiding this comment.
same here its I didn't rename anything in compressed_token/* on purpose so far.
| | File | Current | Proposed | | ||
| |------|---------|----------| | ||
| | `token-sdk/src/compressed_token/ctoken_instruction.rs` | `CTokenInstruction` | `LightTokenInstruction` | | ||
| | `sdk/src/compressible/traits.rs` | `IntoCTokenVariant<V, T>` | `IntoLightTokenVariant<V, T>` | |
Contributor
There was a problem hiding this comment.
Suggested change
| | `sdk/src/compressible/traits.rs` | `IntoCTokenVariant<V, T>` | `IntoLightTokenVariant<V, T>` | | |
| | `sdk/src/compression/traits.rs` | `IntoCTokenVariant<V, T>` | `IntoLightTokenVariant<V, T>` | |
Comment on lines
+37
to
+39
| | `token-sdk/src/pack.rs:301` | `CompressibleTokenDataWithVariant<V> = CTokenDataWithVariant<V>` | Remove alias, use consistent name | | ||
| | `token-sdk/src/pack.rs:303` | `CTokenData<V> = CTokenDataWithVariant<V>` | `LightTokenData<V>` | | ||
| | `token-sdk/src/pack.rs:304` | `PackedCTokenData<V> = PackedTokenDataWithVariant<V>` | `PackedLightTokenData<V>` | |
Contributor
There was a problem hiding this comment.
Suggested change
| | `token-sdk/src/pack.rs:301` | `CompressibleTokenDataWithVariant<V> = CTokenDataWithVariant<V>` | Remove alias, use consistent name | | |
| | `token-sdk/src/pack.rs:303` | `CTokenData<V> = CTokenDataWithVariant<V>` | `LightTokenData<V>` | | |
| | `token-sdk/src/pack.rs:304` | `PackedCTokenData<V> = PackedTokenDataWithVariant<V>` | `PackedLightTokenData<V>` | | |
| | `token-sdk/src/pack.rs:301` | `CompressionTokenDataWithVariant<V> = CTokenDataWithVariant<V>` | Remove alias, use consistent name | | |
| | `token-sdk/src/pack.rs:303` | `CTokenData<V> = CTokenDataWithVariant<V>` | `LightTokenData<V>` | | |
| | `token-sdk/src/pack.rs:304` | `PackedCTokenData<V> = PackedTokenDataWithVariant<V>` | `PackedLightTokenData<V>` | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.