Skip to content

Add LERM transition detection #11

Open
niatimary wants to merge 4 commits into
LinkedEarth:mainfrom
niatimary:feature-lerm
Open

Add LERM transition detection #11
niatimary wants to merge 4 commits into
LinkedEarth:mainfrom
niatimary:feature-lerm

Conversation

@niatimary
Copy link
Copy Markdown
Contributor

Summary

  • Add LERM transition detection
  • Enhance DeterministicTransitions plotting

Changed files

  • core/rqa_res.py
  • core/transitions.py
  • utils/lerm_transitions.py
  • utils/init.py

@CommonClimate
Copy link
Copy Markdown
Contributor

Thanks @niatimary! Can you share a few results (a figure would suffice) or even better a notebook in TyppingPoints, to show how this works?

Copy link
Copy Markdown
Contributor

@CommonClimate CommonClimate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please include figure generated by the docstring plot() call so we can see what this looks like

@niatimary
Copy link
Copy Markdown
Contributor Author

@CommonClimate
This PR adds LERM transition detection capabilities and introduces new utilities (Rupture wrapper + metrics):

New Modules:

  • utils/ruptures_transitions.py
  • utils/metrics.py

Improvements:
-core/rqa_res.py
-core/series.py
-core/transitions.py
-utils/__init__.py

Test:
-tests/test_utils_ruptures.py

Figures showing LERM detection with different block_size values are attached to demonstrate the sensitivity of the ruptures algorithm. Rupture results are also included.

  • LERM validation result for different block_size
image
  • Rupture validation result
image

@CommonClimate
Copy link
Copy Markdown
Contributor

Thanks @niatimary . Can you explain what is on the right-hand side of the first figure? Are you validating against the results of the KS test or to D/O events identified in the literature? In any case, the FI should be shown under the primary timeseries (d18O in this case) so we can compare the timing. Having to look left and right does not help see alignment.

@niatimary
Copy link
Copy Markdown
Contributor Author

@CommonClimate

I fixed the issues and pushed to the TippingPoints repo. For Ammonyte, I added a DetectionMetrics class and a test file to verify it's working correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants