docs: address review findings on README and benchmark scripts#74
Conversation
- gen_page.py and bench_python.py resolve page.html relative to the script's own directory, so the documented repo-root commands work (previously the fixture landed in the caller's cwd and both benchmarks failed to find it). - Fix two README snippets that would not compile as shown (E0716: .first() borrowing the temporary returned by .css()). - Make the scrape_tool example return attrs as a real JSON object, matching its documented tool contract. - Complete the quick-start manifest (serde_json, async-trait), state how the peak-RSS numbers were measured, unambiguous repo-root benchmark commands, and soften 'static binary' / 'zero hidden allocations' claims to what the build actually produces. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KDFsMaKk764vogjUW3nqpk
|
Warning Review limit reached
Next review available in: 51 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 participants
Summary
Follow-up to #73 (merged before the review fixes landed). Addresses all actionable findings from CodeRabbit's review on #73 plus an independent accuracy review:
gen_page.pywrotepage.htmlto the caller's cwd while both benchmarks look for it inscripts/benchmark/— running the documented commands failed. Both scripts now resolve the fixture relative to their own location; all documented commands run from the repo root and were re-verified end-to-end..first()borrowing the temporary returned by.css()) in the DOM Navigation and Regex Extraction sections.scrape_toolexample contract:attrsis now a real JSON object instead of a double-encoded string, matching the doc comment and tool schema shown to the model.serde_json,async-trait), a footnote stating how the peak-RSS numbers were measured, unambiguous benchmark commands, "static binary" → "native binary", "zero hidden allocations" → "cheap tree sharing", and a runnableasync mainaround the SitemapSpider quick start.🤖 Generated with Claude Code
https://claude.ai/code/session_01KDFsMaKk764vogjUW3nqpk
Generated by Claude Code