feat: Update to latest version of packages #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Docker SDK from github.com/docker/docker to the newer github.com/moby/moby client packages. The migration involves updating import paths, adapting to new API signatures, and handling changes in data structure organization.
Changes:
- Migrated from docker/docker to moby/moby client SDK (v1.52.0 for API, v0.2.1 for client)
- Updated all Docker client API calls to use new method signatures and return types
- Adapted code to handle restructured response objects (e.g.,
summary.Items,resp.Container.*)
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| mrunner/runner_deploy.go | Updated Docker client API calls throughout container deployment, inspection, removal, and exec operations; changed filter creation, port parsing, and network configuration to use moby/moby types |
| mrunner/runner.go | Updated import path from docker/docker/client to moby/moby/client |
| go.mod | Added moby/moby/api v1.52.0 and moby/moby/client v0.2.1; removed docker/docker dependency; updated numerous transitive dependencies |
| go.sum | Added checksums for new moby/moby packages and updated transitive dependencies |
| examples/go.work.sum | Updated workspace checksums for new dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just upgrades Magic to the latest version of moby/client (the Docker Engine SDK for Golang).