chore: move styles in Misc to relevant stylesheets#7311
chore: move styles in Misc to relevant stylesheets#7311ElectricalBoy wants to merge 18 commits intomainfrom
Conversation
There was a problem hiding this comment.
could do some more changes i think
lines 11-18 —> Images.scss
lines 67-81 —> Icons.scss?
lines 159-267 —> new sheet? (Links.scss)
lines 323-331 —> Prizepooltable.scss
lines 377-384 —> Faction.scss
lines 386-493 —> new sheet? (Timeline.scss)
lines 539-635 —> new sheet? (Spellcard.scss)
lines 929-1051 —> remove? (for both i don't see any usage via insource search with https://tools.liquipedia.0xff0000.dev/?view=search)
lines 1111-1160 —> check for remaining usage?
lines 1257-1262 —> Faction.scss
lines 1280-1375 —> new sheet? (Placement.scss)
2062-2099 —> Icons.scss?
line numbers are based on https://github.com/Liquipedia/Lua-Modules/blob/dff7d3f85faf97b4e6daf3400c940b4c4012f770/stylesheets/commons/Miscellaneous.scss
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
LGTM
comments optional
| @media ( min-width: 431px ) { | ||
| .showmatch-team-mobile { | ||
| display: none; | ||
| } | ||
| } | ||
|
|
||
| @media ( max-width: 435px ) { | ||
| .showmatch-team-full { | ||
| display: none; | ||
| } | ||
| } |
There was a problem hiding this comment.
only usage in https://liquipedia.net/teamfortress/Template:Showmatch (and some archived stuff)
if someone wants to cvonvert those few (shit looking) old matches to SingleMatch we could kick this
| @media ( min-width: 321px ) { | ||
| .grouptable-team-mobile, | ||
| .matchlist-team-mobile { | ||
| display: none; | ||
| } | ||
| } | ||
|
|
||
| @media ( max-width: 320px ) { | ||
| .grouptable-team-full, | ||
| .matchlist-team-full { | ||
| display: none; | ||
| } | ||
| } |
| @media ( min-width: 300px ) { | ||
| .popover { | ||
| min-width: 275px; | ||
| } | ||
| } |
There was a problem hiding this comment.
only usage is a sandbox user space page from fo on dota2
2 participants
How did you test this change?
N/A; simple cut-paste