Skip to content

Comments

test: add tests#210

Merged
ReenigneArcher merged 5 commits intomasterfrom
test/add-tests
Feb 22, 2026
Merged

test: add tests#210
ReenigneArcher merged 5 commits intomasterfrom
test/add-tests

Conversation

@ReenigneArcher
Copy link
Member

Description

The main scope of the PR is to add tests to the project, but it also does the following:

  • refactors primary function of the update_db.py file to reduce cognitive complexity
  • moves python code to pyproject.toml structure

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher ReenigneArcher force-pushed the test/add-tests branch 2 times, most recently from 29a22b9 to a67df43 Compare February 22, 2026 01:04
Set the CI job to run on ubuntu-latest instead of the matrix runner, standardizing the environment. Fix the update-db workflow to invoke the actual script path (./src/update_db.py) rather than an ambiguous `update-db` command; preserves the conditional '-t' flag for pull_request events.
@codecov
Copy link

codecov bot commented Feb 22, 2026

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Replace setAttribute/getAttribute usage for per-image data attributes with element.dataset access in game_detail.js. Values are now written to bigImgsEl.dataset.imgSrc{n} / imgDesc{n} and read back via dataset, simplifying the code and aligning with standard DOM dataset usage.
Add a Codecov status badge to the README to display the repository's coverage report. The badge links to the project's Codecov page and uses the for-the-badge style for prominent visibility.
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.3% Duplication on New Code (required ≤ 2%)
4 Duplicated Blocks on New Code (required ≤ 0)

See analysis details on SonarQube Cloud

@ReenigneArcher ReenigneArcher marked this pull request as ready for review February 22, 2026 01:26
@ReenigneArcher ReenigneArcher merged commit 05d4a55 into master Feb 22, 2026
16 of 17 checks passed
@ReenigneArcher ReenigneArcher deleted the test/add-tests branch February 22, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant