Skip to content

Comments

fix(platforms): exclude 'games' from platforms/all.json summary#211

Merged
ReenigneArcher merged 1 commit intomasterfrom
fix/platforms/don't-write-games-to-all.json
Feb 22, 2026
Merged

fix(platforms): exclude 'games' from platforms/all.json summary#211
ReenigneArcher merged 1 commit intomasterfrom
fix/platforms/don't-write-games-to-all.json

Conversation

@ReenigneArcher
Copy link
Member

Description

Calculate and attach per-platform game counts as before, but write a lightweight platforms/all.json that omits the full 'games' lists to keep the summary file small (fits GitHub Pages limits). Adds a brief explanatory comment/docstring and builds summary_data without 'games' before calling write_json_files. Updates unit test to verify the 'games' key is not present in the written summary and that game_count and platform name remain correct.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Calculate and attach per-platform game counts as before, but write a lightweight platforms/all.json that omits the full 'games' lists to keep the summary file small (fits GitHub Pages limits). Adds a brief explanatory comment/docstring and builds summary_data without 'games' before calling write_json_files. Updates unit test to verify the 'games' key is not present in the written summary and that game_count and platform name remain correct.
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Feb 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (05d4a55) to head (acd8c4c).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #211   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines         1042      1043    +1     
=========================================
+ Hits          1042      1043    +1     
Flag Coverage Δ
Linux 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/update_db.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05d4a55...acd8c4c. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ReenigneArcher ReenigneArcher merged commit 0531f47 into master Feb 22, 2026
17 checks passed
@ReenigneArcher ReenigneArcher deleted the fix/platforms/don't-write-games-to-all.json branch February 22, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant