feat: add routesetter fields#1119
Conversation
dorthrithil
left a comment
There was a problem hiding this comment.
We should migrate existing setter info from current gym instances. Add a data migration that - if in gym mode - moves the name and dates from the FA fields to the new setter fields.
Also, in the instance settings we have "Standard date format for first ascents/routesetting" which will from now on only affect FA fields as we have the new separate setter fields. The translations need to be changed here. Currently the gym translations also translate lineFANameLabel to setter which should be removed then as this field will be only for FAs in the future.
Maybe we want to hide the actual FA field then in gyms as the FA is not really relevant in gyms, but I'm not sure about that one. What do you think?
Regarding the usage if the setter field for bolters of a line, as you suggested in #1118, should we handle that with relabeling setter by establisher / bolter / cleaner or smth in outdoor mode or also introduce a new field for it? I think in lead it's quite common to have the first ascentionist and bolter being different people. In bouldering its quite rare.
done
seems ok for me - FA really isn't used for gyms, as you say
possibly, but your other suggestion was to only show the setter field in gym mode. |
|
my work pre-commithook prepended all commits with EDIT: i renamed em |
c25057e to
e351b39
Compare
first draft for issue #1118