Skip to content

feat: add routesetter fields#1119

Open
senn wants to merge 7 commits into
LocalCrag:nextfrom
senn:feat/routesetter-fields
Open

feat: add routesetter fields#1119
senn wants to merge 7 commits into
LocalCrag:nextfrom
senn:feat/routesetter-fields

Conversation

@senn
Copy link
Copy Markdown

@senn senn commented Jun 4, 2026

first draft for issue #1118

Copy link
Copy Markdown
Contributor

@dorthrithil dorthrithil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should migrate existing setter info from current gym instances. Add a data migration that - if in gym mode - moves the name and dates from the FA fields to the new setter fields.

Also, in the instance settings we have "Standard date format for first ascents/routesetting" which will from now on only affect FA fields as we have the new separate setter fields. The translations need to be changed here. Currently the gym translations also translate lineFANameLabel to setter which should be removed then as this field will be only for FAs in the future.

Maybe we want to hide the actual FA field then in gyms as the FA is not really relevant in gyms, but I'm not sure about that one. What do you think?

Regarding the usage if the setter field for bolters of a line, as you suggested in #1118, should we handle that with relabeling setter by establisher / bolter / cleaner or smth in outdoor mode or also introduce a new field for it? I think in lead it's quite common to have the first ascentionist and bolter being different people. In bouldering its quite rare.

Comment thread client/src/app/modules/line/line-form/line-form.component.html Outdated
Comment thread client/src/assets/i18n/line/de.json Outdated
Comment thread client/src/assets/i18n/line/de.json Outdated
@senn
Copy link
Copy Markdown
Author

senn commented Jun 4, 2026

We should migrate existing setter info from current gym instances. Add a data migration that - if in gym mode - moves the name and dates from the FA fields to the new setter fields.

i'll look into it done

Also, in the instance settings we have "Standard date format for first ascents/routesetting" which will from now on only affect FA fields as we have the new separate setter fields. The translations need to be changed here. Currently the gym translations also translate lineFANameLabel to setter which should be removed then as this field will be only for FAs in the future.

done

Maybe we want to hide the actual FA field then in gyms as the FA is not really relevant in gyms, but I'm not sure about that one. What do you think?

seems ok for me - FA really isn't used for gyms, as you say

Regarding the usage if the setter field for bolters of a line, as you suggested in #1118, should we handle that with relabeling setter by establisher / bolter / cleaner or smth in outdoor mode or also introduce a new field for it? I think in lead it's quite common to have the first ascentionist and bolter being different people. In bouldering its quite rare.

possibly, but your other suggestion was to only show the setter field in gym mode.
i would leave it as is for now. it could be a nice addition/change in the future

@senn
Copy link
Copy Markdown
Author

senn commented Jun 4, 2026

my work pre-commithook prepended all commits with feat: because it assumes a linked jira ticket is in the message. We should squash them anyway

EDIT: i renamed em

@senn senn force-pushed the feat/routesetter-fields branch from c25057e to e351b39 Compare June 5, 2026 09:55
@senn senn deployed to Cypress June 5, 2026 09:56 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants