docs: DRR enforcement implementation plan for PB (DRR-REST5)#645
Draft
gilliankerr wants to merge 3 commits intodevelopfrom
Draft
docs: DRR enforcement implementation plan for PB (DRR-REST5)#645gilliankerr wants to merge 3 commits intodevelopfrom
gilliankerr wants to merge 3 commits intodevelopfrom
Conversation
Hand-off plan for PB. Revises the scope in drr-enforcement-tests-prompt.md from ~30 PRs down to ~16, front-loads CI/Postgres/missing-controls foundation, favours Django system checks over tests over Semgrep, and defers fuzzy rules to a weekly Haiku workflow. Scope and priority revision based on a four-expert panel review (Security, PHIPA Compliance, Nonprofit Sustainability, SRE). Open questions for GK listed at the foot of the document. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Fixes 11 issues flagged in the end-of-session review: Scope gaps - Add PR 3.7 (test_demo_isolation.py, DRR 1.5) - Add PR 3.8 (test_terminology_substitution.py, DRR 3.2) - Add PR 3.9 (test_stack_constraints.py, DRR 4.1) - Add PR 3.10 (test_demo_model_coverage.py, schema-sync meta-check) Accuracy - Replace "~16 PRs" claim with honest count: ~21 code + 1 ops + ~9 frontmatter = ~31 total - Fix dangling [konote-ops](konote-ops) link in PR 1.3 - Make PR 1.3 explicitly blocking for PR 2.1; call out it's a separate repo - Update Phase 5 cross-ref to PR 3.7 (no longer says "add if needed") Safety / governance - PII pre-flight guard in Phase 6 (refuse to send diffs containing *.sql/*.dump/data/ files to Anthropic — PHIPA concern) - Reorder open questions: DV flag two-person enforcement is now #1 and explicitly blocks Phase 3.6 - Add new OQ #6 on documenting the invariant/mechanism split as a DRR authoring convention - Turn Phase 4 promotion criteria into an explicit checklist - Specify kill-switch escalation path (Gillian first, then Llewelyn.ca ops) - Update order-of-operations recap with 3.7-3.10 and blocking arrows Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Pre-amends the DRR per GK sign-off 2026-04-13 on the six open questions from the implementation plan review. Adds a designated emergency approver role so agencies that cannot always guarantee two qualified approvers still preserve two-person semantics — a distinct second human is always involved; only the role-match requirement is relaxed for time-critical cases. - Replaces the "emergency override bypass" anti-pattern with language that distinguishes bypass (forbidden) from named-role approver (permitted with audit flag + weekly review). - Updates the enforcement pytest description to include the emergency-approver audit-flag assertion. - Extends CI enforcement detail with sub-test (d) covering the emergency path. - Assigns DRR-REST5 to PB in TODO.md and references PR #645. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pboachie
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tasks/drr-enforcement-tests-prompt.md(~30 PRs, one per artifact) down to ~16 PRs in 7 phases.Why this differs from the original prompt
Four-expert panel review (Security, PHIPA Compliance, Nonprofit Sustainability, SRE) flagged:
developPRs; SQLite in CI can't support PG-role tests.AuditLoginstance-level overrides, two-person helper module).Open questions for GK
Listed at the foot of the plan. Key ones:
ConsentEvent.save()override?Status
Draft PR — not for merge until GK + PB review the approach. Kept as draft so comments happen on the plan itself.
Test plan
🤖 Generated with Claude Code