fix: use versioned Python path on macOS install#3
Open
GregcodeOhm wants to merge 2 commits intoLucterios2:masterfrom
Open
fix: use versioned Python path on macOS install#3GregcodeOhm wants to merge 2 commits intoLucterios2:masterfrom
GregcodeOhm wants to merge 2 commits intoLucterios2:masterfrom
Conversation
On systems where the unversioned "python3" symlink points to macOS system Python (3.9) or a newer unsupported Homebrew version (3.14), the install script fails with a version check error. This fix resolves the installed Python by its explicit versioned path (e.g. python3.13) under $BREW_PATH/bin, and also upgrades the hard-coded python@3.11 to a cascading install (3.13 > 3.12 > 3.11 > 3.10). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
After the venv is activated, $PYTHON_CMD points to the system Python (outside the venv) where PyQt6 is not installed. This causes the import to fail, and set -e kills the script before creating the .app bundle. Use `python` (resolved by the active venv) and add `|| true` to handle the case where PyQt6 is not available. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
brew install python@3.13does not create an unversionedpython3symlink. The script then falls back to/usr/bin/python3(system Python 3.9) or picks up an unsupported version like 3.14, causing the install to fail.$BREW_PATH/bin/python3.13) instead of relying on the unversionedpython3.python@3.11to a cascading install (3.13 || 3.12 || 3.11 || 3.10).Reproduction
python3symlink in/opt/homebrew/bin/python@3.13successfully, then callspython3 --version→ gets system 3.9 → Error: Not Python 3.10, 3.11, 3.12 or 3.13 (but 3.9)Test plan
python3already points to a supported version (should still work)python3points to 3.14 via Homebrew🤖 Generated with Claude Code