Conversation
- Changed STARTUP_PURGE to a standard multiline Creality prime sequence to improve initial lines. - Improved ENABLE_MESH_ON_START to include Z10 fade height. - Removed G29 stripping from sanitize_startup_line to preserve bed mesh generation. - Completely removed the intrusive seam tuning and speed caps during seams to prevent inaccuracy and poor loop closures on small squares and circles. - Updated gcode_repair._insert_after to properly handle inserting multiline strings.
- Changed STARTUP_PURGE to a standard multiline Creality prime sequence to improve initial lines. - Improved ENABLE_MESH_ON_START to include Z10 fade height. - Removed G29 stripping from sanitize_startup_line to preserve bed mesh generation. - Completely removed the intrusive seam tuning and speed caps during seams to prevent inaccuracy and poor loop closures on small squares and circles. - Updated gcode_repair._insert_after to properly handle inserting multiline strings. - Removed temporary patch files created during the debugging session.
- Added hardcoded thresholds and limits for bed dimensions and skirt offset in config.py. - Updated gcode_emit.py to utilize KLIPPER_MESH_ENABLE for mesh processing. - Improved gcode_repair.py to dynamically find print bounding boxes and adjust skirt generation accordingly. - Enhanced gcode_tune.py with configurable PEEK_SLICER_FAN_WINDOW and PEEK_RETRACT_WINDOW. - Modified profile.py to auto-detect filament type and nozzle diameter, with TPU-specific adjustments for speed and retraction settings.
- Introduced PrintBoundingBoxScanner and ContourSkirtGenerator classes to enhance G-code bounding box detection and skirt generation. - Implemented IRepairStep interface and specific repair steps for homing, mesh leveling, and hotend temperature checks to improve G-code integrity. - Updated profile.py with helper functions for better configuration management, prioritizing user-defined settings over defaults.
- Introduced GCodeBuilder class to encapsulate G-code generation methods, improving modularity and readability. - Updated ContourSkirtGenerator and various repair steps in gcode_repair.py to utilize GCodeBuilder for generating skirt and repair commands. - Removed redundant standalone functions in gcode_emit.py, enhancing code organization and maintainability.
…lasses - Introduced SpeedTuner and RetractionTuner classes to improve G-code tuning for speed and retraction settings. - Refactored existing functions into class methods, enhancing modularity and readability. - Updated fan tuning logic to utilize new class structures, streamlining the tuning process. - Removed redundant standalone functions, improving code organization and maintainability.
…atureScanner classes - Introduced IFeatureScanner interface and GCodeFeatureScanner class to enhance modularity in G-code feature detection. - Refactored type_feature function into a method within GCodeFeatureScanner, improving code organization and readability. - Updated gcode_transform.py to utilize the new GCodeFeatureScanner for feature classification, streamlining the transformation process.
…roved logging - Introduced ILogger interface to define a standard logging contract for G-code processing. - Implemented DefaultLogger class to provide default logging functionality, enhancing modularity and readability. - Refactored run_postprocess method to utilize the new logging structure, improving error handling and logging consistency. - Updated action summarization and result logging to be handled by DefaultLogger, streamlining the logging process.
…eline - Introduced abc module import to enable the use of abstract base classes, enhancing the extensibility of the G-code processing pipeline. - This change lays the groundwork for future modular enhancements and interface implementations.
- Added abstract base classes (IBundleConfig, IGCodeAnalyzer, IGCodeValidator, IExportFinder, IGCodePatternMatcher, IStateLogger) to enhance the extensibility and modularity of the G-code processing framework. - Implemented concrete classes (BundleConfig, GCodeAnalyzer, RecentExportFinder, GCodePatternMatcher, StateLogger) to provide specific functionalities while adhering to the defined interfaces. - Refactored existing functions to utilize the new class structures, improving code organization and maintainability across various modules.
- Introduced new abstract methods in IGCodeAnalyzer for post-processing checks, fan line counting, and pressure advance detection to improve G-code analysis capabilities. - Implemented these methods in GCodeAnalyzer, enhancing its functionality for analyzing G-code files. - Refactored GCodeValidator to utilize the new methods for improved validation logic, ensuring more accurate error and warning reporting. - Updated the logging and analysis processes in PostProcessApp to align with the new structure, enhancing overall modularity and maintainability.
- Modified the condition for post-processing checks in PostProcessApp to utilize the new analyzer method for improved accuracy. - This change enhances the validation process by ensuring that only properly analyzed G-code is processed further, aligning with recent refactoring efforts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.