Update figures - THIS WILL BE CLOSED DO NOT USE#123
Draft
imenelydiaker wants to merge 11 commits intomainfrom
Draft
Update figures - THIS WILL BE CLOSED DO NOT USE#123imenelydiaker wants to merge 11 commits intomainfrom
imenelydiaker wants to merge 11 commits intomainfrom
Conversation
wissam-sib
reviewed
Jun 5, 2024
| MODELS_TO_IGNORE = ['voyage-01', 'voyage-02', 'voyage-lite-01'] | ||
| MODELS_TO_IGNORE = ['voyage-01', 'voyage-02', 'voyage-lite-01', 'Geotrend/distilbert-base-en-fr-es-pt-it-cased', | ||
| 'Geotrend/bert-base-10lang-cased', 'Geotrend/bert-base-15lang-cased', 'Geotrend/bert-base-25lang-cased', | ||
| 'dangvantuan/sentence-camembert-large', 'distilbert-base-uncased'] |
There was a problem hiding this comment.
why ignoring sentence-camembert-large? It was one of the best models
Author
There was a problem hiding this comment.
Because there is a newer version: Lajavaness/sentence-camembert-large, see description in this link. They say it's better than the other one.
I see that Lajavaness proposes a sentence-flaubert, maybe we should add it instead of flaubert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #117