Add empty NanaZip.ExtensionPackage.#617
Conversation
|
Thanks. It looks good, but I think it's necessary to add the check for ARM64 Windows because I don't want ARM64 Windows users to install the x64 version by accident. It will reduce lots of issues. Microsoft introduced the x64 application support for ARM64 Windows, and x64 reuses the same system files from ARM64 via ARM64X, starting with Windows 11 Build 22000. For the shell extension in the extension package you will contribute in the near future, I hope it can run out-of-process like NanaZip pacakged shell extensions. (running in dllhost.exe process) It can avoid us making ARM64X binaries for that. (This reduces some issues and binary sizes.) Kenji Mouri |
|
Converted to Inno Setup for eventual universal extension package installer. |
e7e3bb6 to
1cf3a7f
Compare
|
Maybe we can use https://www.nuget.org/packages/Tools.InnoSetup instead of installing Inno Setup toolchain separately to make a better out-of-box build experience. Kenji Mouri |
|
If you don't trust the unofficial one, you can also provide the InnoSetup toolchain binary files in the NanaZip.ExtensionPackage\Tools folder, similar as https://github.com/M2Team/NanaRun/tree/main/Tools does. But I think that NuGet package seems have a good reputation. Kenji Mouri |
|
Done using Tools.InnoSetup 6.4.2. |
|
Also, there are some suggestions:
Kenji Mouri |
Done: I've set
This is actually done in |
Add NanaZip.ExtensionPackage in preparation for #502.