Skip to content

Add empty NanaZip.ExtensionPackage.#617

Merged
dinhngtu merged 1 commit into
M2Team:mainfrom
dinhngtu:ext-pkg
Apr 7, 2025
Merged

Add empty NanaZip.ExtensionPackage.#617
dinhngtu merged 1 commit into
M2Team:mainfrom
dinhngtu:ext-pkg

Conversation

@dinhngtu

@dinhngtu dinhngtu commented Apr 5, 2025

Copy link
Copy Markdown
Member

Add NanaZip.ExtensionPackage in preparation for #502.

@dinhngtu dinhngtu requested a review from MouriNaruto April 5, 2025 03:14
@MouriNaruto

MouriNaruto commented Apr 5, 2025

Copy link
Copy Markdown
Member

Thanks.

It looks good, but I think it's necessary to add the check for ARM64 Windows because I don't want ARM64 Windows users to install the x64 version by accident. It will reduce lots of issues. Microsoft introduced the x64 application support for ARM64 Windows, and x64 reuses the same system files from ARM64 via ARM64X, starting with Windows 11 Build 22000.

For the shell extension in the extension package you will contribute in the near future, I hope it can run out-of-process like NanaZip pacakged shell extensions. (running in dllhost.exe process) It can avoid us making ARM64X binaries for that. (This reduces some issues and binary sizes.)

Kenji Mouri

@dinhngtu

dinhngtu commented Apr 6, 2025

Copy link
Copy Markdown
Member Author

Converted to Inno Setup for eventual universal extension package installer.

@dinhngtu dinhngtu force-pushed the ext-pkg branch 2 times, most recently from e7e3bb6 to 1cf3a7f Compare April 6, 2025 06:51
@MouriNaruto

Copy link
Copy Markdown
Member

Maybe we can use https://www.nuget.org/packages/Tools.InnoSetup instead of installing Inno Setup toolchain separately to make a better out-of-box build experience.

Kenji Mouri

@MouriNaruto

MouriNaruto commented Apr 6, 2025

Copy link
Copy Markdown
Member

If you don't trust the unofficial one, you can also provide the InnoSetup toolchain binary files in the NanaZip.ExtensionPackage\Tools folder, similar as https://github.com/M2Team/NanaRun/tree/main/Tools does.

But I think that NuGet package seems have a good reputation.

Kenji Mouri

@dinhngtu

dinhngtu commented Apr 6, 2025

Copy link
Copy Markdown
Member Author

Done using Tools.InnoSetup 6.4.2.

Comment thread NanaZip.ExtensionPackage/NanaZip.ExtensionPackage.Installer.iss
Comment thread NanaZip.ExtensionPackage/NanaZip.ExtensionPackage.Installer.iss Outdated
Comment thread NanaZip.ExtensionPackage/NanaZip.ExtensionPackage.Installer.iss Outdated
@MouriNaruto

MouriNaruto commented Apr 6, 2025

Copy link
Copy Markdown
Member

Also, there are some suggestions:

  • Add the detect logic to ensure the 64-Bit only support.
  • I hope the script will automatically update the build number.

Kenji Mouri

@dinhngtu

dinhngtu commented Apr 7, 2025

Copy link
Copy Markdown
Member Author

Also, there are some suggestions:

  • Add the detect logic to ensure the 64-Bit only support.

Done: I've set ArchitecturesAllowed and ArchitecturesInstallIn64BitMode in my new push.

  • I hope the script will automatically update the build number.

This is actually done in NanaZip.ExtensionPackage/NanaZip.ExtensionPackage.Installer.proj. The AppVersion here is purely a fallback.

@dinhngtu dinhngtu merged commit ab308d0 into M2Team:main Apr 7, 2025
@dinhngtu dinhngtu deleted the ext-pkg branch April 7, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants