Improve safe teleportation location finding#12
Open
bjorn-out wants to merge 1 commit intoMCCitiesNetwork:mainfrom
Open
Improve safe teleportation location finding#12bjorn-out wants to merge 1 commit intoMCCitiesNetwork:mainfrom
bjorn-out wants to merge 1 commit intoMCCitiesNetwork:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where searching for a safe teleport location in very tall regions often times out before a valid spot is found.
Currently, the search starts at the vertical center of the region. For regions that span from bedrock to build height, this means the search often spends most of its time checking empty air.
This PR updates the search behavior for very tall plots to begin around
y=80, as long as that height falls within the region. This significantly improves the chance of finding a safe location before the search times out.