fix(mastodon): improve autocompletion scan performance and UX#899
Open
kastwey wants to merge 1 commit intoMCV-Software:next-genfrom
Open
fix(mastodon): improve autocompletion scan performance and UX#899kastwey wants to merge 1 commit intoMCV-Software:next-genfrom
kastwey wants to merge 1 commit intoMCV-Software:next-genfrom
Conversation
- Fix O(n²) to O(1) complexity when checking for duplicate users The original code used `if user not in list` which caused scans to hang for hours on accounts with many followers. Now uses dict keyed by user ID for instant lookups. - Add detailed progress dialog with: - Account info (followers/following/total counts) - Current status and page number - Users processed counter - Visual progress bar - Cancel button to stop scan gracefully - Refactor scan logic into reusable _scan_users() method with ScanType enum. - Show accurate completion stats (new users vs already in database). - Fix window close behavior (X button now cancels instead of crashing). - Add 15 unit tests for storage and scan logic. - Fix storage.__del__ to handle already-closed connections.
jmdaweb
approved these changes
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which is faster and more idiomatic for large datasets.