Scope Linux-only dependencies to Linux platforms #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi, I’ve opened a PR that scopes Linux-only dependencies (Brlapi, python-apt, systemd-python) using platform markers in both requirements.txt and simulations.txt. This fixes the cross-platform installation failure on Windows/macOS while preserving Linux compatibility. Please let me know if you’d like any changes. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes cross-platform installation failures on Windows and macOS caused by Linux-only dependencies listed in dependency files.
Although PR #97 removed the apturl blocker, installation still fails on non-Linux systems because the following Ubuntu/Linux-specific packages are included unconditionally:
Brlapi
python-apt
systemd-python
These packages are not available on PyPI for Windows or macOS, which causes pip install to fail.
What changed
Added platform_system == "Linux" markers to Linux-only dependencies in:
requirements.txt
simulations.txt
This ensures:
Dependencies are installed normally on Linux
pip safely skips them on Windows/macOS
How to reproduce
On Windows/macOS:
pip install -r requirements.txt
Before: Installation fails with
No matching distribution found for Brlapi
After: Installation proceeds successfully
Environment
OS: Windows 10
Python: 3.11.9
Fresh virtual environment
Related issue
Fixes #103