[DOP-35394] Add descendants relations to hierarchy requests#423
Draft
[DOP-35394] Add descendants relations to hierarchy requests#423
Conversation
dolfinus
reviewed
Apr 1, 2026
| result.parents.update(await self._uow.job.list_ancestor_relations(ids)) | ||
| result.parents.update(await self._uow.job.list_descendant_relations(ids)) | ||
|
|
||
| # Collect all job nodes for the response |
Member
There was a problem hiding this comment.
Let's move this under else: block
Contributor
Author
There was a problem hiding this comment.
As I understand moving under else: is not enough for correct collecting data I should use new variable level (simular to LineageService)
dolfinus
reviewed
Apr 1, 2026
| # Cover both inferred links connected to task0 and task4. | ||
| edge_task_ids = [tasks[0].id, tasks[4].id] | ||
| # Cover both inferred links connected to spark0 and spark4. | ||
| edge_task_ids = [sparks[0].id, sparks[4].id] |
Member
There was a problem hiding this comment.
Suggested change
| edge_task_ids = [sparks[0].id, sparks[4].id] | |
| edge_spark_ids = [sparks[0].id, sparks[4].id] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Change allgorithm of collecting job hierarchy. Now for each step we collect all ansectors and descendants.
Related issue number
[DOP-35394]
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rstfile added describing change(see CONTRIBUTING.rst for details.)