Draft
Conversation
added 7 commits
April 20, 2024 05:55
This only works with todo items that are newly added, as the old data format lacks enough information to construct an edit modal (e.g. ascension and current exp). This new data format has been marked as "formatVersion 2". The old incomplete format is implicitly "formatVersion 1", though this isn't relevant anywhere in the code as the old data format lacks a `formatVersion` property. Some code has been moved out of _weapon.svelte and into other scripts in order to avoid repeated code between it and the new TodoEditWeaponModal.svelte. The old weapon level material calculation algorithm (`process` in _weapon.svelte) has been replaced by a new heuristic (resourceCalculator.calculateWeaponLevelMaterials). In some cases the new algorithm wastes more EXP (by a negligible amount) but allows Mystic Enhancement Ore to be disabled depending on user choice. It was previously enabled permanently as it narrowed the material combinations `process` had to crawl through. New displayed text has only been added for English. Other locales have empty strings currently.
(Prior the obtainable item list would simply be empty on Sundays, which might make the user think that *no* items are obtainable on Sundays, rather than the other way around)
Editing only works with character todo items that are newly added, for the same reasons preventing old weapon todo items from being edited, as mentioned in f541b03. Some code has been moved out of _character.svelte and into other scripts in order to avoid repeated code between it and the new TodoCharacterWeaponModal.svelte. Both replace the `resolve` function for calculating EXP materials with `resourceCalculator.calculateCharacterLevelMaterials`. This is purely for consistency with the weapon calculation code, because unlike the case with weapons, `calculateCharacterLevelMaterials` doesn't enable any functionality that wasn't possible before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demonstration of editing character todo with ascension
Demonstration of editing character todo without ascension
Demonstration of editing weapon todo
Demonstration of editing on mobile
New locale text has only been added for English. The keys exist on the other locale jsons, but the strings are left blank.