chore: refactor typeahead#233
Open
urs-van-binsbergen wants to merge 2 commits into
Open
Conversation
urs-van-binsbergen
force-pushed
the
pr/refactor-typeahead
branch
from
7751ec0 to
857df2f
Compare
belafonte
requested changes
May 7, 2026
Contributor
belafonte
left a comment
belafonte
left a comment
There was a problem hiding this comment.
Maybe not important, but we spoke about the loading indicator while fetching data.
Minimal UX regression and might not be needed to reimplement. Just noting it here ;)
urs-van-binsbergen
force-pushed
the
pr/refactor-typeahead
branch
from
857df2f to
2cb9db9
Compare
Contributor
Author
|
Reintroduced the loading spinner. |
belafonte
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Madek/Madek#886
Wait with merge until after Release 4.14.0