Skip to content

Fix: typo in Invoice Reports status filter label ("Submmitted" → "Submitted")#157

Open
LiamStanziani wants to merge 1 commit into
MagentaHealth:release/2026-03-17from
openo-beta:bug/typos-in-oscar-gui-base-release
Open

Fix: typo in Invoice Reports status filter label ("Submmitted" → "Submitted")#157
LiamStanziani wants to merge 1 commit into
MagentaHealth:release/2026-03-17from
openo-beta:bug/typos-in-oscar-gui-base-release

Conversation

@LiamStanziani

@LiamStanziani LiamStanziani commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

Corrects a spelling mistake in the Ontario billing Invoice Reports screen, where the
"Submitted OHIP" status-filter radio button was mislabelled "Submmitted OHIP" (double "m").
This is a one-line, display-only text change with no functional impact.

Original PR: openo-beta#2484

Problem

In Admin Panel → Billing → Invoice Reports, the radio button used to filter invoices by
status rendered its label as "Submmitted OHIP" instead of "Submitted OHIP". The misspelling
was visible to every user of the Ontario billing reporting screen.

  • File: src/main/webapp/billing/CA/ON/billingONStatus.jsp
  • Element: statusType radio button, value="B"

Solution

Corrected the label text from Submmitted to Submitted.

                             <label class="radio inline"><input type="radio" name="statusType"
-                                                               value="B" <%=statusType.equals("B")?"checked":""%>>Submmitted
+                                                               value="B" <%=statusType.equals("B")?"checked":""%>>Submitted
                                 OHIP</label>

UI Before:

image

UI After:

Screenshot_20260624_164329

Only the user-visible label text was changed. The radio button's value="B" — the value submitted
to the server and used for filtering — is untouched, so there is no behavioural or data change.

Testing

  • Visual verification: the radio button on the Invoice Reports screen now reads "Submitted OHIP".
  • No logic, request parameters, or stored values were modified.

Summary by Sourcery

Bug Fixes:

  • Fix the misspelled "Submmitted OHIP" status radio label to display "Submitted OHIP" in the Invoice Reports screen.

@LiamStanziani LiamStanziani self-assigned this Jun 25, 2026
@sourcery-ai

sourcery-ai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR makes a single, display-only text correction to the Ontario billing Invoice Reports status filter, fixing a typo in the label of the "Submitted OHIP" radio button without changing any underlying status values or logic.

File-Level Changes

Change Details Files
Fix the misspelled label text for the "Submitted OHIP" status radio button in the Ontario Invoice Reports screen.
  • Update the user-visible label text from "Submmitted" to "Submitted" for the statusType radio button with value "B".
  • Confirm that the radio button name, value ("B"), and checked-state logic remain unchanged, preserving existing filtering behavior.
src/main/webapp/billing/CA/ON/billingONStatus.jsp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@LiamStanziani LiamStanziani marked this pull request as ready for review June 25, 2026 14:25

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@LiamStanziani LiamStanziani requested a review from lacarmen June 25, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant