Skip to content

mapcache_seed: Refactor seeder for robust multiprocessing and shutdown #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marisn wants to merge 2 commits into
base: main
Choose a base branch
from
Open

mapcache_seed: Refactor seeder for robust multiprocessing and shutdown #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77b589b
mapcache_seed: Refactor seeder for robust multiprocessing and shutdown
marisn Sep 2, 2025
6239413
Test mapcache_seed parallel worker mode
marisn Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 63 additions & 6 deletions tests/run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

# Project: MapCache
# Purpose: MapCache tests
# Author: Even Rouault
# Author: Even Rouault, Maris Nartiss
#
#*****************************************************************************
# Copyright (c) 2017 Regents of the University of Minnesota.
# Copyright (c) 2017, 2025 Regents of the University of Minnesota.
#
# Permission is hereby granted, free of charge, to any person obtaining a
# copy of this software and associated documentation files (the "Software"),
Expand All @@ -30,10 +30,10 @@ set -e

MAPCACHE_CONF=/tmp/mc/mapcache.xml

sudo rm -rf /tmp/mc/global
rm -rf /tmp/mc/global
mapcache_seed -c /tmp/mc/mapcache.xml -t global --force -z 0,1
gdalinfo -checksum /tmp/mc/global/GoogleMapsCompatible/00/000/000/000/000/000/000.jpg | grep Checksum=20574 >/dev/null || (echo "Did not get expected checksum"; gdalinfo -checksum /tmp/mc/global/GoogleMapsCompatible/00/000/000/000/000/000/000.jpg; /bin/false)
sudo rm -rf /tmp/mc/global
gdalinfo /tmp/mc/global/GoogleMapsCompatible/00/000/000/000/000/000/000.jpg | grep "Size is 256, 256" >/dev/null || (echo "Invalid image size"; gdalinfo /tmp/mc/global/GoogleMapsCompatible/00/000/000/000/000/000/000.jpg; /bin/false)
rm -rf /tmp/mc/global

curl -s "http://localhost/mapcache/?SERVICE=WMS&REQUEST=GetCapabilities" | xmllint --format - > /tmp/wms_capabilities.xml
diff -u /tmp/wms_capabilities.xml expected
Expand All @@ -42,8 +42,65 @@ curl -s "http://localhost/mapcache/wmts?SERVICE=WMTS&REQUEST=GetCapabilities" |
diff -u /tmp/wmts_capabilities.xml expected

curl -s "http://localhost/mapcache/wmts/1.0.0/global/default/GoogleMapsCompatible/0/0/0.jpg" > /tmp/0.jpg
gdalinfo -checksum /tmp/0.jpg | grep Checksum=20574 >/dev/null || (echo "Did not get expected checksum"; gdalinfo -checksum /tmp/0.jpg; /bin/false)
gdalinfo /tmp/0.jpg | grep "Size is 256, 256" >/dev/null || (echo "Invalid image size"; gdalinfo /tmp/0.jpg; /bin/false)

curl -s "http://localhost/mapcache/wmts/1.0.0/global/default/GoogleMapsCompatible/0/0/0.jpg" > /tmp/0_bis.jpg
diff /tmp/0.jpg /tmp/0_bis.jpg


# --- Test parallel seeding ---
echo "== Testing parallel seeding with -p 4 =="
rm -rf /tmp/mc/global
mapcache_seed -c /tmp/mc/mapcache.xml -t global --force -z 0,2 -p 4
gdalinfo /tmp/mc/global/GoogleMapsCompatible/00/000/000/000/000/000/000.jpg | grep "Size is 256, 256" >/dev/null || (echo "Invalid image size for tile 0/0/0"; gdalinfo /tmp/mc/global/GoogleMapsCompatible/00/000/000/000/000/000/000.jpg; /bin/false)
gdalinfo /tmp/mc/global/GoogleMapsCompatible/01/000/000/000/000/000/000.jpg | grep "Size is 256, 256" >/dev/null || (echo "Invalid image size for tile 1/0/0"; gdalinfo /tmp/mc/global/GoogleMapsCompatible/01/000/000/000/000/000/000.jpg; /bin/false)
gdalinfo /tmp/mc/global/GoogleMapsCompatible/02/000/000/000/000/000/000.jpg | grep "Size is 256, 256" >/dev/null || (echo "Invalid image size for tile 2/0/0"; gdalinfo /tmp/mc/global/GoogleMapsCompatible/02/000/000/000/000/000/000.jpg; /bin/false)
echo "OK: Parallel seeding with -p 4 successful"
rm -rf /tmp/mc/global

# --- Test parallel seeding with -p 1 ---
echo "== Testing parallel seeding with -p 1 =="
rm -rf /tmp/mc/global
mapcache_seed -c /tmp/mc/mapcache.xml -t global --force -z 0,2 -p 1
gdalinfo /tmp/mc/global/GoogleMapsCompatible/00/000/000/000/000/000/000.jpg | grep "Size is 256, 256" >/dev/null || (echo "Invalid image size for tile 0/0/0"; exit 1)
gdalinfo /tmp/mc/global/GoogleMapsCompatible/01/000/000/000/000/000/000.jpg | grep "Size is 256, 256" >/dev/null || (echo "Invalid image size for tile 1/0/0"; exit 1)
gdalinfo /tmp/mc/global/GoogleMapsCompatible/02/000/000/000/000/000/000.jpg | grep "Size is 256, 256" >/dev/null || (echo "Invalid image size for tile 2/0/0"; exit 1)
echo "OK: Parallel seeding with -p 1 successful"
rm -rf /tmp/mc/global

# --- Test graceful shutdown ---
echo "== Testing graceful shutdown of parallel seeder =="
rm -rf /tmp/mc_shutdown
mkdir -p /tmp/mc_shutdown
cp /tmp/mc/mapcache.xml /tmp/mc/mapcache_shutdown.xml
sed -i 's|<base>/tmp/mc</base>|<base>/tmp/mc_shutdown</base>|' /tmp/mc/mapcache_shutdown.xml
# Run seeder in the background, in its own process group
set -m
mapcache_seed -c /tmp/mc/mapcache_shutdown.xml -t global -z 0,8 -p 4 -q &
PID=$!
set +m
# Give it a moment to start seeding
sleep 2
PGID=$(ps -o pgid= $PID | xargs)
if [ -z "$PGID" ]; then
echo "Could not get PGID of seeder process. Test cannot continue."
exit 1
fi
# Send SIGINT to the process group
echo "Sending SIGINT to process group $PGID"
kill -INT -$PGID
# Wait for the process to terminate, with a timeout
if wait $PID 2>/dev/null; then
echo "OK: Seeder terminated gracefully on SIGINT"
else
# The process might have already exited and `wait` fails.
# Let's check if it's still running.
if ps -p $PID > /dev/null; then
echo "Error: Seeder did not terminate gracefully"
kill -9 -$PGID
exit 1
else
echo "OK: Seeder terminated gracefully on SIGINT"
fi
fi
rm -rf /tmp/mc_shutdown
Loading