feat: add archlinux pkgbuild#1
Merged
Merged
Conversation
selckin
added a commit
to selckin/gitkay
that referenced
this pull request
Jun 24, 2026
The near-bottom +500 lazy-load reassigned self.commits and rebuilt graph_rows but skipped everything reload_commits does afterward, so search_matches, the selection, and branch-ancestry highlight kept pointing at the old list. Symptoms: matches in the freshly-loaded tail were never found; ancestry of the selected commit that landed in the tail stayed dimmed; and a stale search_matches index could reach compute_branch_highlight's commits[idx] and panic if the list shrank (virtual rows dropping, or refs changing). Extract the post-load re-sync from reload_commits into a shared resync_commits() and route both paths through it. Selection re-anchors by oid (by index for reflog), clamped to the new length, so a shrink falls back to a valid row instead of crashing. Found by /code-review (findings Marenz#1-4).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.