Conversation
There was a problem hiding this comment.
Summary
This PR adds a changelog entry for version 0.2.2 documenting a Windows code signature verification fix. However, there's a critical missing element: the comparison link [0.2.2] at the bottom of the file is absent, which breaks the "compare" links in the changelog. Additionally, both 0.2.1 and 0.2.2 share the same date (2026-02-14), which seems unintentional.
Critical
CHANGELOG.md:121— Missing version comparison link for 0.2.2: The new version 0.2.2 has no corresponding comparison link at the bottom of the file. All other versions (0.1.8, 0.2.0, 0.2.1) have[version]: https://github.com/.../compare/...links. Add[0.2.2]: https://github.com/MarkPDFdown/markpdfdown-desktop/compare/0.2.1...0.2.2at the bottom to match the existing pattern.
Important
CHANGELOG.md:6— Duplicate dates for sequential releases: Both 0.2.1 and 0.2.2 are dated 2026-02-14. If 0.2.1 was released earlier in the day, consider using a different date (e.g., 2026-02-15) or clarify in the description that these were released on the same day.
Suggestion
CHANGELOG.md:9— PR reference in commit message: The entry already includes the PR referencePR [#42]in parentheses, which is good. However, the commit hash link also points to PR #42. Consider simplifying to avoid redundancy, e.g.,- **build**: 📦 disable code signature verification for Windows updates (by @jorben)since the commit hash already links to the PR.
Praise
CHANGELOG.md:6-9— Proper Keep a Changelog format: The new entry correctly uses the## [version] - dateheader,### :bug: Bug Fixescategory, and includes the commit hash, PR reference, and contributor attribution. This follows the project's chosen changelog convention well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated changelog update for release 0.2.2.
Comparing changes from
0.2.1to0.2.2.This PR was automatically created by the changelog workflow.