Skip to content

fix: add click as explicit dependency#1751

Merged
bhirsz merged 1 commit into
MarketSquare:mainfrom
Meizzajanor:Meizzajanor/fix-click-runtime-dep
May 26, 2026
Merged

fix: add click as explicit dependency#1751
bhirsz merged 1 commit into
MarketSquare:mainfrom
Meizzajanor:Meizzajanor/fix-click-runtime-dep

Conversation

@Meizzajanor
Copy link
Copy Markdown
Contributor

@Meizzajanor Meizzajanor commented May 26, 2026

This pull request makes a minor update to the project's dependencies by adding a new requirement to the pyproject.toml file.

  • Added click>=8.0.0 to the list of dependencies in pyproject.toml to ensure the project has the necessary CLI framework installed.

Closes #1750 .

Copilot AI review requested due to automatic review settings May 26, 2026 16:23
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds click as an explicit runtime dependency in the project configuration.

Changes:

  • Add click>=8.0.0 to dependencies in pyproject.toml.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pyproject.toml
Copy link
Copy Markdown
Member

@bhirsz bhirsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vendoring, ugh.. thanks for the report & fix! I consider this as critical issue so I will make a release right away (8.2.9 or 8.3.0 since I have also updated fastmcp recently to major version).

@bhirsz bhirsz merged commit 47ee186 into MarketSquare:main May 26, 2026
11 checks passed
@bhirsz
Copy link
Copy Markdown
Member

bhirsz commented May 26, 2026

And congratz on 1000th PR in Robocop repository :)

nvuillam added a commit to oxsecurity/megalinter that referenced this pull request May 26, 2026
8.2.9 adds click as an explicit dependency, fixing the ModuleNotFoundError
introduced when typer 0.26.0 vendored click and dropped it as a transitive
dependency (upstream fix: MarketSquare/robotframework-robocop#1751).
nvuillam added a commit to oxsecurity/megalinter that referenced this pull request May 26, 2026
* chore(deps): update alpine/terragrunt docker tag to v1.15.4

* ignore false positive

* chore: ignore four Go stdlib CVEs not reachable in static-analysis linters

CVE-2025-22871 (net/http bare LF), CVE-2025-58189 (TLS ALPN handshake),
CVE-2025-61725 (net/mail ParseAddress), CVE-2025-61727 (crypto/x509
subdomain constraint). None reachable in Go CLI linters that read local
files and make no inbound TLS, HTTP, or mail-parsing calls.

* fix(robocop): bump robotframework-robocop to 8.2.9

8.2.9 adds click as an explicit dependency, fixing the ModuleNotFoundError
introduced when typer 0.26.0 vendored click and dropped it as a transitive
dependency (upstream fix: MarketSquare/robotframework-robocop#1751).

* fix(robocop): read version from package metadata; robocop --version is broken

robocop 8.2.9 mixes externally-installed click with typer 0.26's vendored
click. The 'click.version_option' decorator on the typer group silently
fails to register --version, so 'robocop --version' returns 'No such option'.
Use the venv's Python and importlib.metadata to read the installed version
until upstream fixes the typer/click integration.

* fix(robocop): drop offending word from descriptor comment to satisfy cspell

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: nvuillam <nicolas.vuillamy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

click is imported but not listed as direct dependency, causing issues with typer 0.26.0

3 participants