Security: Unsafe Path Traversal in File Operations#1753
Open
tomaioo wants to merge 1 commit into
Open
Conversation
Multiple locations in the codebase construct file paths without proper validation. In `tests/formatter/formatters/GenerateDocumentation/test_formatter.py`, `template_path` is constructed from `Path(__file__).parent / "source" / "template_with_defaults.txt"` and passed to configuration. In `src/robocop/linter/reports/text_file.py`, the `output_path` is configurable and used directly with `Path(value)` and `open()`. While `mkdir(parents=True, exist_ok=True)` is used, there's no validation that the path doesn't escape intended directories. The `json_report.py` similarly uses configurable paths. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Unsafe Path Traversal in File Operations
Problem
Severity:
Medium| File:src/robocop/linter/reports/text_file.py:L56Multiple locations in the codebase construct file paths without proper validation. In
tests/formatter/formatters/GenerateDocumentation/test_formatter.py,template_pathis constructed fromPath(__file__).parent / "source" / "template_with_defaults.txt"and passed to configuration. Insrc/robocop/linter/reports/text_file.py, theoutput_pathis configurable and used directly withPath(value)andopen(). Whilemkdir(parents=True, exist_ok=True)is used, there's no validation that the path doesn't escape intended directories. Thejson_report.pysimilarly uses configurable paths.Solution
Validate that configured output paths are within allowed directories. Use
path.resolve().relative_to(base_dir)checks to prevent path traversal. Consider adding asafe_pathutility that rejects paths containing..or absolute paths when user-configurable.Changes
src/robocop/linter/reports/text_file.py(modified)