HIR planning: Also cast element type after CastInt2VectorToArray#35015
Open
ggevay wants to merge 1 commit intoMaterializeInc:mainfrom
Open
HIR planning: Also cast element type after CastInt2VectorToArray#35015ggevay wants to merge 1 commit intoMaterializeInc:mainfrom
CastInt2VectorToArray#35015ggevay wants to merge 1 commit intoMaterializeInc:mainfrom
Conversation
Pre-merge checklist
|
eeeb926 to
b5a48b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/MaterializeInc/database-issues/issues/10087 and https://github.com/MaterializeInc/database-issues/issues/10088. The bug was that our
The
Int2VectortoArraycast used to just blindly say that the cast succeeds by simply adding a call toCastInt2VectorToArraywithout regard to the Array's element type. The fix is to check the Array element type, and if it's notInt2, then additionally insert an array to array cast that attends to the element type (or fail the cast if the element types are not castable).Btw. Junie (RustRover's AI agent) with Opus 4.6 oneshotted the fix in <5 minutes, which I think is super impressive. I only needed to adjust the tests and the code comment, plus manually tested Postgres compat.