Release/v6.1.1#83
Conversation
- Guard userMessageContentReady on last content block to prevent race conditions with parallel native tool calls - Resolve pending ask on command auto-approval so subsequent commands don't retain stale UI state - Refactor attemptCompletionTool feedback to use pushToolResult - Add handleRunEverythingClick prop to ExplorationGroupRow
When an exec command inside an exploration group requires the user to click Run/Cancel buttons, the collapsed view would hide them. Auto-expand the group in this case and collapse back after the command is handled.
There was a problem hiding this comment.
🧪 PR Review is completed: Release v6.1.1 contains solid race-condition fixes and AGENTS.md loading improvements. Found 2 issues: a missing nullish coalescing on user feedback text and a copy-paste translation key error in the create-file UI path.
Skipped files
webview-ui/src/i18n/locales/en/chat.json: Skipped file pattern
| const feedbackContent: (Anthropic.TextBlockParam | Anthropic.ImageBlockParam)[] = [ | ||
| { | ||
| type: "text", | ||
| text: `The user has provided feedback on the results. Consider their input to continue the task, and then attempt completion again.\n<feedback>\n${text}\n</feedback>`, |
There was a problem hiding this comment.
🟡 Logic Error
Issue: The template literal interpolates text directly without a fallback. If text is undefined (which the old code explicitly guarded against with text ?? ""), the string "undefined" is injected into the feedback block sent to the LLM.
Fix: Preserve the nullish coalescing fallback inside the template literal.
Impact: Prevents garbage "undefined" text from appearing in model context when a user submits feedback without text.
| text: `The user has provided feedback on the results. Consider their input to continue the task, and then attempt completion again.\n<feedback>\n${text}\n</feedback>`, | |
| text: `The user has provided feedback on the results. Consider their input to continue the task, and then attempt completion again.\n<feedback>\n${text ?? ""}\n</feedback>`, |
| : tool.isProtected | ||
| ? t("chat:fileOperations.wantsToEditProtected") |
There was a problem hiding this comment.
🟡 Logic Error
Issue: In the create-file UI branch (non-partial, protected), the translation key chat:fileOperations.wantsToEditProtected is used instead of chat:fileOperations.wantsToCreateProtected. This is a copy-paste error from the edit-file branch above and causes the wrong label to be shown when the model wants to create a protected file.
Fix: Use the create-specific translation key to match the surrounding create-file keys.
Impact: Correct UI label for protected file creation requests.
| : tool.isProtected | |
| ? t("chat:fileOperations.wantsToEditProtected") | |
| ? t("chat:fileOperations.wantsToCreateProtected") |
|
|
||
| CRITICAL: For any task, small or big, you will always and always use the update_todo_list tool to create the TODO list, always keep is upto date with updates to the status and updating/editing the list as needed. | ||
| `, | ||
| CRITICAL: For any task, small or big, you will always and always use the update_todo_list tool to create the TODO list, always keep is upto date with updates to the status and updating/editing the list as needed.`, |
There was a problem hiding this comment.
🟡 Code Quality
Issue: The newly added CRITICAL instruction contains grammatical errors ("keep is upto date" instead of "keep it up to date") that could reduce clarity for the model parsing this system prompt.
Fix: Correct the typos and streamline the sentence for better readability.
Impact: Ensures the system prompt is grammatically correct and clearly understood by the AI model.
| CRITICAL: For any task, small or big, you will always and always use the update_todo_list tool to create the TODO list, always keep is upto date with updates to the status and updating/editing the list as needed.`, | |
| CRITICAL: For any task, small or big, you will always and always use the update_todo_list tool to create the TODO list, always keep it up to date with status updates and edit it as needed.`, |
No description provided.