Feat : plug progress bar on namespace event bus#56
Open
Conversation
pboiseau
suggested changes
Mar 7, 2019
| }() | ||
|
|
||
| //register for event listening | ||
| ns.AddListener("cli_progress_bar") |
Contributor
There was a problem hiding this comment.
I suggest to register the listener before starting the watcher to prevent missing event
|
|
||
| //Init timer | ||
| timerCh := time.NewTimer(timeout).C | ||
| doneCh := make(chan bool) |
Contributor
There was a problem hiding this comment.
I suggest to make a buffered chanel make(chan bool, 1) because you will only put one value inside and exist the func after so the goroutine will stop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR plus the progress bar shown when the
-waitis passed to theapplycommand. on the event system.