Skip to content

feat: add Dockerfiles for development and production images#7

Open
firefly2442 wants to merge 1 commit intoMegaMek:mainfrom
firefly2442:docker
Open

feat: add Dockerfiles for development and production images#7
firefly2442 wants to merge 1 commit intoMegaMek:mainfrom
firefly2442:docker

Conversation

@firefly2442
Copy link
Copy Markdown
Contributor

No description provided.

@exeea
Copy link
Copy Markdown
Collaborator

exeea commented Sep 25, 2025

I think is a bit overkill to run it in docker. For development you only really need to run ng serve and you need angular/cli installed anyway.

@firefly2442
Copy link
Copy Markdown
Contributor Author

I like Docker even for development because it's basically a one line command to get up and running. Otherwise, you need to go install NodeJS, make sure it's the right version, etc. All of that can clutter up your system and be one more thing to manage and update. This way, all you need to do is build and run the container.

@exeea
Copy link
Copy Markdown
Collaborator

exeea commented Sep 26, 2025

I, too, love docker, but I don't see the advantage here: you need nodejs to develop, or else you are missing almost everything for the IDE to work properly (and console commands too).

@firefly2442
Copy link
Copy Markdown
Contributor Author

OK, would you like me to pull that part out and leave the production Dockerfile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants