feat: add Dockerfiles for development and production images#7
Open
firefly2442 wants to merge 1 commit intoMegaMek:mainfrom
Open
feat: add Dockerfiles for development and production images#7firefly2442 wants to merge 1 commit intoMegaMek:mainfrom
firefly2442 wants to merge 1 commit intoMegaMek:mainfrom
Conversation
Collaborator
|
I think is a bit overkill to run it in docker. For development you only really need to run |
Contributor
Author
|
I like Docker even for development because it's basically a one line command to get up and running. Otherwise, you need to go install NodeJS, make sure it's the right version, etc. All of that can clutter up your system and be one more thing to manage and update. This way, all you need to do is build and run the container. |
Collaborator
|
I, too, love docker, but I don't see the advantage here: you need nodejs to develop, or else you are missing almost everything for the IDE to work properly (and console commands too). |
Contributor
Author
|
OK, would you like me to pull that part out and leave the production Dockerfile? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.