MC:2978 Added utm source, utm medium and utm campaign at login flow #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
sidharthv96
requested changes
Apr 30, 2025
packages/sdk/src/index.ts
Outdated
Comment on lines
75
to
86
| public async getAuthorizationData({ | ||
| state, | ||
| scope = ['email'], | ||
| utm_source, | ||
| utm_medium, | ||
| utm_campaign | ||
| }: { | ||
| state?: string; | ||
| scope?: string[]; | ||
| utm_source?: string; | ||
| utm_medium?: string; | ||
| utm_campaign?: string; |
Member
There was a problem hiding this comment.
If you need all three present to send the tracking link, then it should be evident in the type. Otherwise the consumer of the SDK (some other plugin developer), might just send one, and be confused why it's not being sent, without looking inside the implementation.
Suggested change
| public async getAuthorizationData({ | |
| state, | |
| scope = ['email'], | |
| utm_source, | |
| utm_medium, | |
| utm_campaign | |
| }: { | |
| state?: string; | |
| scope?: string[]; | |
| utm_source?: string; | |
| utm_medium?: string; | |
| utm_campaign?: string; | |
| public async getAuthorizationData({ | |
| state, | |
| scope = ['email'], | |
| tracking | |
| }: { | |
| state?: string; | |
| scope?: string[]; | |
| tracking?: { | |
| utm_source: string; | |
| utm_medium: string; | |
| utm_campaign: string; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added utm_source, utm_medium, and utm_campaign parameters to the
getAuthorizationDatamethod in theMermaidChartclass for analytics