fix(assets-controllers): parallelize chain processing in token detection #7590
+23
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Current State
The
TokenDetectionController#detectTokensUsingRpcmethod processes blockchain networks sequentially using afor...awaitloop. When multiple networks are enabled (e.g., 20 networks in MetaMask Mobile), each chain must complete token detection before the next chain can start. This creates a severe performance bottleneck:This makes the app feel frozen and causes users to think it has crashed.
Solution
This PR refactors
#detectTokensUsingRpcto execute all chains in parallel:for...awaitloop toPromise.allSettled()with parallel executionallSettledinstead ofallso one failing chain doesn't block successful onesPerformance Impact
Implementation Details
The change follows the same pattern already used successfully in:
TokenRatesController.ts:436CurrencyRateController.ts:255References
Checklist