feat: update token metadata service to include RWA data in API requests #7595
+20
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified token service URLs to append `includeRwaData=true` for fetching token data. - Updated related test cases to reflect the new API request structure. - Adjusted `TokenListController` to support RWA data in token list retrieval. This change enhances the token service functionality by allowing the inclusion of RWA data in the responses, improving the overall data richness for consumers.
Prithpal-Sooriya
commented
Jan 9, 2026
Comment on lines
+24
to
+26
| // 4 Hour Interval Cache Refresh Threshold | ||
| const DEFAULT_INTERVAL = 4 * 60 * 60 * 1000; | ||
| const DEFAULT_THRESHOLD = 4 * 60 * 60 * 1000; |
Contributor
Author
There was a problem hiding this comment.
As discussed in slack - we have modified the cache interval from 24 hours to 4 hours.
We should monitor if this causes any performance hits - (mostly from the large writes to state)
Contributor
There was a problem hiding this comment.
I thought we wanted to pass this in constructor client side instead of updating the controller's default values?
Contributor
Author
There was a problem hiding this comment.
meeeeh I don't mind either or... But this would minimise client changes required. Open to options on this :)
Contributor
There was a problem hiding this comment.
Hmmm agree, tbh doing it on constructor seems to be the proper way to go about this.
Doing it in this controller is less changes for sure;
I don't mind tbh, if you feel like you prefer this one, happy to approve 🙏
Contributor
Author
There was a problem hiding this comment.
Sweet, lets do it inside the controller for now -- less changes that devs need to make. We can treat the ones inside the constructor as "overrides" if it needs to be overridden.
Prithpal-Sooriya
commented
Jan 9, 2026
| return `/tokens/${convertHexToDecimal( | ||
| chainId, | ||
| )}?occurrenceFloor=3&includeNativeAssets=false&includeTokenFees=false&includeAssetType=false&includeERC20Permit=false&includeStorage=false`; | ||
| )}?occurrenceFloor=3&includeNativeAssets=false&includeTokenFees=false&includeAssetType=false&includeERC20Permit=false&includeStorage=false&includeRwaData=true`; |
Contributor
Author
There was a problem hiding this comment.
We have a PR to update to the new endpoint #7572
However this is postponed to reduce the scope of changes for the RWA feature launch.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Prithpal-Sooriya
force-pushed
the
ASSETS-2205/update-token-metadata-to-support-rwa-data
branch
from
832bbcc to
cfb24ed
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Contributor
Author
|
Preview build here: MetaMask/metamask-extension#39129 |
Contributor
Author
|
Demo on extension with tokens that have RWA data. |
sahar-fehri
approved these changes
Jan 9, 2026
Prithpal-Sooriya
deleted the
ASSETS-2205/update-token-metadata-to-support-rwa-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
includeRwaData=truefor fetching token data.TokenListControllerto support RWA data in token list retrieval.This change enhances the token service functionality by allowing the inclusion of RWA data in the responses, improving the overall data richness for consumers.
References
Checklist
Note
Adds RWA metadata support to token list retrieval and shortens cache refresh window.
includeRwaData=trueto token list API calls infetchTokenListByChainId; update tests accordinglyTokenListControllertoken type with optionalrwaData(TokenRwaData)TokenListControllercache interval/threshold from 24h to 4hCHANGELOG.mdWritten by Cursor Bugbot for commit cb897e9. This will update automatically on new commits. Configure here.