chore: enable test build#42304
Open
salimtb wants to merge 136 commits into
Open
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (2 files, +76 -7)
👨🔧 @MetaMask/core-extension-ux (1 files, +16 -5)
🫰 @MetaMask/core-platform (2 files, +78 -3)
👨🔧 @MetaMask/extension-platform (2 files, +9 -3)
🕵️ @MetaMask/extension-privacy-reviewers (6 files, +174 -85)
🧪 @MetaMask/qa (12 files, +282 -114)
🔄 @MetaMask/swaps-engineers (3 files, +4 -9)
👨🔧 @itsyoboieltr (1 files, +3 -3)
|
Contributor
Builds ready [4ed304b]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Prithpal-Sooriya
force-pushed
the
feat/migration-207-assets-controller
branch
from
9de9f22 to
f89c28b
Compare
We did not correct the balance for those tokens.
Prithpal-Sooriya
force-pushed
the
feat/migration-207-assets-controller
branch
from
f89c28b to
e29b3ef
Compare
davibroc
added
the
no-changelog
Contributor
Builds ready [425b0c4]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [f2671f1]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 7 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Builds ready [074abde]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 8 warn · 🔴 1 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [385b22f]
⚡ Performance Benchmarks (Total: 🟢 15 pass · 🟡 9 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Prithpal-Sooriya
previously approved these changes
May 21, 2026
Contributor
Builds ready [5505619] [reused from 55aa91e]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 0 warn · 🔴 0 fail)
Bundle size diffs
|
Prithpal-Sooriya
previously approved these changes
May 27, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c7c186e. Configure here.
Contributor
Builds ready [c7c186e]
⚡ Performance Benchmarks (Total: 🟢 21 pass · 🟡 4 warn · 🔴 0 fail)
Bundle size diffs
|
Prithpal-Sooriya
previously approved these changes
May 27, 2026
Contributor
Builds ready [4e70e40] [reused from c7c186e]
⚡ Performance Benchmarks (Total: 🟢 21 pass · 🟡 4 warn · 🔴 0 fail)
Bundle size diffs
|
1 similar comment
Contributor
Builds ready [4e70e40] [reused from c7c186e]
⚡ Performance Benchmarks (Total: 🟢 21 pass · 🟡 4 warn · 🔴 0 fail)
Bundle size diffs
|
|
Contributor
Builds ready [596b0a0] [reused from 4854e43]
⚡ Performance Benchmarks (Total: 🟢 23 pass · 🟡 2 warn · 🔴 0 fail)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Large E2E and fixture churn around balances, pricing, and
AssetsControllerstate increases flake risk; production behavior only changes via build env and theIN_TESTflag bypass, not end-user release defaults by themselves.Overview
Turns on assets unified state for CI E2E (
ASSETS_UNIFIED_STATE_ENABLED: 'true') and stops forcing it off in test builds viaset-environment-variables.js, so the extension and tests align on the unified assets path.Runtime / gating:
isAssetsUnifyStateFeatureEnabledreturnstruewhenprocess.env.IN_TESTis set (documented for E2E/unit). Suites that need the disabled-flag path override the helper with pure flag evaluation (noIN_TESTbypass). New unit tests cover both behaviors.E2E / fixtures: Default fixture and
FixtureBuilderV2gainAssetsControllerdata and safer merge/overwrite; global mocks always wire Tokens/Accounts APIs (no env branching). Helpers sync localhost native balance from the local node; many specs add price/token/network mocks, longer waits, and updated metrics/state-log snapshots. Benchmark onboarding flows temporarily skip web vitals (bug #42792).Product/tests: UI multichain transaction display falls back to
assetsMetadatawhen Snap movements have emptyunit; new hook tests. Import-token unit test for disabled unify path removed as redundant with the new gating model.Reviewed by Cursor Bugbot for commit 596b0a0. Bugbot is set up for automated code reviews on this repo. Configure here.