Allow for more recent versions of grumphp#10
Open
synterra wants to merge 1 commit intoMetadrop:masterfrom
Open
Allow for more recent versions of grumphp#10synterra wants to merge 1 commit intoMetadrop:masterfrom
synterra wants to merge 1 commit intoMetadrop:masterfrom
Conversation
Currently `phpro/grumphp` installs as `v1.5.0` which isn't compatible with PHP 8.1. I see numerous warnings when using GrumPHP and PHP 8.1, including: ``` Deprecated: strlen(): Passing null to parameter Metadrop#1 ($string) of type string is deprecated in /var/www/html/vendor/symfony/filesystem/Filesystem.php on line 125 PHP Deprecated: file_exists(): Passing null to parameter Metadrop#1 ($filename) of type string is deprecated in /var/www/html/vendor/symfony/filesystem/Filesystem.php on line 129 ``` Newer versions of the library should fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
phpro/grumphpinstalls asv1.5.0which isn't compatible with PHP 8.1. I see numerous warnings when using GrumPHP and PHP 8.1, including:Newer versions of the library should fix it.