fix: implement connection timeout limits and launch splash cut-off#107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements network request timeout limits and prevents the app launch splash screen from hanging indefinitely when the active server is offline or slow.
Key Changes
URLSessioninsideNetworkClientto use a 15-second request and resource timeout interval (down from the default 60 seconds).withThrowingTaskGroup. If connection fails to establish within 3 seconds, the logintask is cancelled and the app falls back to the Server List rather than freezing on the logo screen.
401 Unauthorizedresponses in the background telemetry loop to trigger a silent background re-authentication attempt.testSendRequest_TimeoutandtestTaskGroup_TimeoutRacetoNetworkClientTeststo verify request cancellation and timeout propagation.