fix: track list multi-selection by info-hash instead of Torrent objects#108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves an issue where active multiple-selection checkmarks would disappear from the list view on the next 2-second background telemetry sync poll.
Key Changes
selectedTorrentsstate insideTorrentListHelperViewModelfromSet<Torrent>toSet<String>(tracking unique info-hashes).Torrentproperties (speeds, progress, ETA) change on every sync poll, the struct's default synthesized hash value changes. Trackingselections by immutable String hashes ensures selection states persist during telemetry updates.
testSelection_PersistsAcrossTelemetryRefreshusing a reactiveXCTestExpectationmodel update to verify that selection states remain intact when a mocktorrent's speeds and progress are updated.